Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queued betting #28

Closed
SiIason opened this issue Jan 31, 2021 · 2 comments · Fixed by #51
Closed

Queued betting #28

SiIason opened this issue Jan 31, 2021 · 2 comments · Fixed by #51
Labels
enhancement New feature or request

Comments

@SiIason
Copy link

SiIason commented Jan 31, 2021 •
edited
Loading

Currently you can not bet on a second bet until the initial closes/completes.

Is it possible to put all betting opportunities into a holding list.
Stay focused on one bet until the bet is made ~90 seconds (then hand it off for another process to deal with completion).
Take the next oldest betting opportunity from the holding list and check if it's newer than 90seconds (current bet wait time)
If newer than 90s then wait for prediction time to pass to 90s and place bet, else drop bet as missed.
(repeat until list empty)

This would mean splitting the information collection of finished bets to a separate check/thread (if it isn't already)
No interaction is required this is for user feedback report only.
@SiIason SiIason added the enhancement New feature or request label Jan 31, 2021
@Tkd-Alex
Copy link
Owner

Tkd-Alex commented Feb 1, 2021

This can be handling multiple problems.
The prediction windows It's not always 90 seconds, but can be dynamic.

How many times you got multiple bet simultaneously? I think It's really rare that It's happened.
I don't think I'll work on a queue system for the bet, but we can try to execute the methods

Twitch-Channel-Points-Miner-v2/TwitchChannelPointsMiner/classes/TwitchBrowser.py

Line 267 in 3357c3b

def start_bet(self, event: EventPrediction):

Twitch-Channel-Points-Miner-v2/TwitchChannelPointsMiner/classes/TwitchBrowser.py

Line 302 in 3357c3b

def place_bet(self, event: EventPrediction):

One after the other, instead of the current system:

  1. start_bet
  2. wait x seconds
  3. place_bet

And see if it works

Tkd-Alex added a commit that referenced this issue Feb 1, 2021
@Tkd-Alex
Call self.start_bet(event) inside place_bet(event) - Attempt to speed…
1dee172 
…-up the bet system so we don't need to make a pause and skip others bet -- https://github.com/Tkd-Alex/Twitch-Channel-Points-Miner-v2/issues/28\#issuecomment-771075169 #28
@SiIason
Copy link
Author

SiIason commented Feb 2, 2021 •
edited
Loading

As far as how often does this happen, I agree normally its rare.
However during events and the like I noticed it's common for multiple streams to run prediction bets etc, and this is where I've noticed the issue.

@Tkd-Alex Tkd-Alex mentioned this issue Feb 5, 2021
Merged
Seillama referenced this issue in Seillama/Twitch-Channel-Points-Miner-v2 Oct 26, 2021
@Tkd-Alex
Call self.start_bet(event) inside place_bet(event) - Attempt to speed…
ed408ba 
…-up the bet system so we don't need to make a pause and skip others bet -- https://github.com/Tkd-Alex/Twitch-Channel-Points-Miner-v2/issues/28\#issuecomment-771075169 #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiple bet improvement: filter, stealth_mode Tkd-Alex/Twitch-Channel-Points-Miner-v2
2 participants
@SiIason @Tkd-Alex